RFR: 8331048: G1: Prune rebuild candidates based on G1HeapWastePercent early [v3]

Thomas Schatzl tschatzl at openjdk.org
Fri May 3 06:27:53 UTC 2024


On Thu, 2 May 2024 16:46:22 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi, 
>> 
>> Please review this change that moves the `G1CollectionSetChooser::build` out of the cleanup pause into the remark pause. This prunes the rebuild candidates based on G1HeapWastePercent, thereby reducing the rebuild time in cases where pruning happens. 
>> 
>> Testing: Tier 1 - 5
>> 
>> ![concurrent_rebuild](https://github.com/openjdk/jdk/assets/69453999/b14dd9d7-24e7-43ed-bf0f-5d3030d9180f)
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactor cleanup

Thanks for the changes. Lgtm.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18970#pullrequestreview-2037466405


More information about the hotspot-gc-dev mailing list