RFR: 8331048: G1: Prune rebuild candidates based on G1HeapWastePercent early [v5]

Ivan Walulya iwalulya at openjdk.org
Fri May 3 10:07:10 UTC 2024


> Hi, 
> 
> Please review this change that moves the `G1CollectionSetChooser::build` out of the cleanup pause into the remark pause. This prunes the rebuild candidates based on G1HeapWastePercent, thereby reducing the rebuild time in cases where pruning happens. 
> 
> Testing: Tier 1 - 5
> 
> ![concurrent_rebuild](https://github.com/openjdk/jdk/assets/69453999/b14dd9d7-24e7-43ed-bf0f-5d3030d9180f)

Ivan Walulya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into PruneBeforeRebuild
 - revert method name
 - Merge remote-tracking branch 'upstream/master' into PruneBeforeRebuild
 - Refactor cleanup
 - Thomas Review
 - remove methods
 - Merge branch 'master' into PruneBeforeRebuild
 - remove Fixme
 - cleanup
 - Merge branch 'master' into GroupOldRegions_Remsets
 - ... and 3 more: https://git.openjdk.org/jdk/compare/298de23b...ddc3df65

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18970/files
  - new: https://git.openjdk.org/jdk/pull/18970/files/a42cfbd1..ddc3df65

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18970&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18970&range=03-04

  Stats: 6 lines in 6 files changed: 1 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18970.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18970/head:pull/18970

PR: https://git.openjdk.org/jdk/pull/18970


More information about the hotspot-gc-dev mailing list