RFR: 8331048: G1: Prune rebuild candidates based on G1HeapWastePercent early [v5]

Albert Mingkun Yang ayang at openjdk.org
Fri May 3 10:18:57 UTC 2024


On Fri, 3 May 2024 10:07:10 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi, 
>> 
>> Please review this change that moves the `G1CollectionSetChooser::build` out of the cleanup pause into the remark pause. This prunes the rebuild candidates based on G1HeapWastePercent, thereby reducing the rebuild time in cases where pruning happens. 
>> 
>> Testing: Tier 1 - 5
>> 
>> ![concurrent_rebuild](https://github.com/openjdk/jdk/assets/69453999/b14dd9d7-24e7-43ed-bf0f-5d3030d9180f)
>
> Ivan Walulya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into PruneBeforeRebuild
>  - revert method name
>  - Merge remote-tracking branch 'upstream/master' into PruneBeforeRebuild
>  - Refactor cleanup
>  - Thomas Review
>  - remove methods
>  - Merge branch 'master' into PruneBeforeRebuild
>  - remove Fixme
>  - cleanup
>  - Merge branch 'master' into GroupOldRegions_Remsets
>  - ... and 3 more: https://git.openjdk.org/jdk/compare/79c39247...ddc3df65

Marked as reviewed by ayang (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18970#pullrequestreview-2037835386


More information about the hotspot-gc-dev mailing list