RFR: 8331402: G1: Remove is_active() calls in G1HRPrinter logging [v3]
Thomas Schatzl
tschatzl at openjdk.org
Fri May 3 12:20:05 UTC 2024
> Hi all,
>
> the `is_active()` call for the various G1HRPrinter methods is unnecessary as the `log_trace()` call will do the exact same check again anyway.
>
> Testing: gha, local compilation
>
> Based on #19058.
>
> Hth,
> Thomas
Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'master' into submit/8331402-g1hrprinter-remove-is_active
- 8331402
The is_active() call for the various G1HRPrinter methods is unnecessary as the log_trace() call will do the exact same check again anyway.
Hth,
Thomas
- 8331401
The HRPrinter does not have any member variables (static or non-static), so it can be made AllStatic.
I.e. there is no reason to have an instance variable around.
Testing: gha
Hth,
Thomas
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19061/files
- new: https://git.openjdk.org/jdk/pull/19061/files/25f24c1a..a94a2b18
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19061&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19061&range=01-02
Stats: 3919 lines in 204 files changed: 1311 ins; 615 del; 1993 mod
Patch: https://git.openjdk.org/jdk/pull/19061.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19061/head:pull/19061
PR: https://git.openjdk.org/jdk/pull/19061
More information about the hotspot-gc-dev
mailing list