RFR: 8331562: G1: Remove API to force allocation of new regions [v2]

Thomas Schatzl tschatzl at openjdk.org
Fri May 3 13:12:57 UTC 2024


On Thu, 2 May 2024 16:18:01 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into submit/8331562-remove-force-allocation-api
>>  - 8331562
>>    
>>    Hi all,
>>    
>>      this change removes the API to allow forced allocation of new regions in G1. Before region pinning,
>>    G1 would force allocations of new regions beyond the calculated young gen limit while the gclocker
>>    had been active.
>>    
>>    With region pinning, this forced allocation is not necessary any more.
>>    
>>    Testing: local compilation, gha
>>    
>>    Hth,
>>      Thomas
>>  - 8331402
>>    
>>    The is_active() call for the various G1HRPrinter methods is unnecessary as the log_trace() call will do the exact same check again anyway.
>>    
>>    Hth,
>>      Thomas
>>  - 8331401
>>    
>>     The HRPrinter does not have any member variables (static or non-static), so it can be made AllStatic.
>>    
>>    I.e. there is no reason to have an instance variable around.
>>    
>>    Testing: gha
>>    
>>    Hth,
>>      Thomas
>
> Marked as reviewed by ayang (Reviewer).

Thanks @albertnetymk @walulyai @lgxbslgx for your reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19062#issuecomment-2092988247


More information about the hotspot-gc-dev mailing list