RFR: 8331569: G1: Rename G1HRPrinter to G1HeapRegionPrinter [v3]

Thomas Schatzl tschatzl at openjdk.org
Fri May 3 13:33:24 UTC 2024


> Hi all,
> 
>   please review this rename of G1HRPrinter to G1HeapRegionPrinter to remove the abbreviation.
> 
> This change has been split into two commits:
> 1) rename the files, adapt includes
> 2) rename the class
> 
> I believe the changes are small so using two commits instead of two CRs/PRs is doable.
> 
> Based on #19062.
> 
> Testing: compliation, gha
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'master' into 8331569-rename-g1hrprinter
 - rename class
 - 8331569
   
   Hi all,
   
     please review this rename of G1HRPrinter to G1HeapRegionPrinter to remove the abbreviation.
   
   This change has been split into two commits:
   1) rename the files, adapt includes
   2) rename the class
   
   I believe the changes are small so using two commits instead of two CRs/PRs is doable.
   
   Testing: compliation, gha
   
   Thanks,
     Thomas
 - 8331562
   
   Hi all,
   
     this change removes the API to allow forced allocation of new regions in G1. Before region pinning,
   G1 would force allocations of new regions beyond the calculated young gen limit while the gclocker
   had been active.
   
   With region pinning, this forced allocation is not necessary any more.
   
   Testing: local compilation, gha
   
   Hth,
     Thomas
 - 8331402
   
   The is_active() call for the various G1HRPrinter methods is unnecessary as the log_trace() call will do the exact same check again anyway.
   
   Hth,
     Thomas
 - 8331401
   
    The HRPrinter does not have any member variables (static or non-static), so it can be made AllStatic.
   
   I.e. there is no reason to have an instance variable around.
   
   Testing: gha
   
   Hth,
     Thomas

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19063/files
  - new: https://git.openjdk.org/jdk/pull/19063/files/d44828e0..19f1d492

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19063&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19063&range=01-02

  Stats: 3985 lines in 214 files changed: 1350 ins; 617 del; 2018 mod
  Patch: https://git.openjdk.org/jdk/pull/19063.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19063/head:pull/19063

PR: https://git.openjdk.org/jdk/pull/19063


More information about the hotspot-gc-dev mailing list