RFR: 8329203: Parallel: Investigate Mark-Compact for Full GC to decrease memory usage [v2]

Albert Mingkun Yang ayang at openjdk.org
Mon May 6 18:11:07 UTC 2024


On Mon, 6 May 2024 12:01:12 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - review
>>  - Merge branch 'master' into pgc-full-gc
>>  - pgc-full-gc
>
> src/hotspot/share/gc/parallel/psParallelCompact.cpp line 752:
> 
>> 750: 
>> 751: public:
>> 752:   virtual void do_oop(oop* p)                { do_oop_work(p); }
> 
> I know that we don't do this very consistently in HotSpot, but the virtual modifier doesn't make much sense here. What *would* make sense is the override keyword.

Will change this and other methods in this file to `override` in a followup PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19101#discussion_r1591369409


More information about the hotspot-gc-dev mailing list