RFR: 8330275: Crash in XMark::follow_array [v6]

[Ashutosh Mehra]

On Wed, 8 May 2024 15:43:37 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restore the comment around max addressable memory but leave out actual numbers that can be confusing
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/cpu/aarch64/gc/x/xGlobals_aarch64.cpp line 147:
> 
>> 145: // Default value if probing is not implemented for a certain platform: 128TB
>> 146: static const size_t DEFAULT_MAX_ADDRESS_BIT = 47;
>> 147: // Minimum value returned, if probing fails: 64GB
> 
> any reason you removed the comment for MINIMUM_MAX_ADDRESS_BIT?

oh! I think I misunderstood stefank's suggestion. I should have just removed the values 64GB and 128TB mentioned in the comment. Let me restore the rest.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18941#discussion_r1594310310