RFR: 8331924: Parallel: Remove unused MutableSpace::mangle_unused_area_complete
Thomas Schatzl
tschatzl at openjdk.org
Wed May 8 17:13:56 UTC 2024
On Wed, 8 May 2024 12:03:21 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Trivial removing dead code.
Lgtm, feel free to ignore the comments about the blank lines. Trivial too.
src/hotspot/share/gc/parallel/mutableNUMASpace.hpp line 176:
> 174: virtual void clear(bool mangle_space);
> 175: virtual void mangle_unused_area() PRODUCT_RETURN;
> 176:
Not sure that a blank line is needed here. There hasn't been any before.
src/hotspot/share/gc/parallel/mutableSpace.hpp line 112:
> 110: // Methods used in mangling. See descriptions under SpaceMangler.
> 111: virtual void mangle_unused_area() PRODUCT_RETURN;
> 112:
Not sure if a blank line is needed here. There has not been any before.
-------------
Marked as reviewed by tschatzl (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19137#pullrequestreview-2046221903
PR Review Comment: https://git.openjdk.org/jdk/pull/19137#discussion_r1594356368
PR Review Comment: https://git.openjdk.org/jdk/pull/19137#discussion_r1594355827
More information about the hotspot-gc-dev
mailing list