RFR: 8331905: Fix direct includes of g1_globals.hpp

Kim Barrett kbarrett at openjdk.org
Wed May 8 17:14:06 UTC 2024


Please review this change to eliminate direct #includes of g1_globals.hpp,
which does nothing useful. Instead, ensure that gc_globals.hpp is included in
all such places. Sometimes gc_globals.hpp was already included, so the include
of g1_globals.hpp is simply deleted. Otherwise, the included file is changed
and placement in the include list adjusted if needed to conform to HotSpot
include order rules.

In some cases it was not obvious that the globals inclusion was needed at all,
but I didn't explore removing any.

Testing: mach5 tier1

-------------

Commit messages:
 - avoid direct includes of g1_globals.hpp

Changes: https://git.openjdk.org/jdk/pull/19144/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19144&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331905
  Stats: 22 lines in 9 files changed: 5 ins; 7 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/19144.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19144/head:pull/19144

PR: https://git.openjdk.org/jdk/pull/19144


More information about the hotspot-gc-dev mailing list