RFR: 8331905: Fix direct includes of g1_globals.hpp

Thomas Schatzl tschatzl at openjdk.org
Wed May 8 17:56:54 UTC 2024


On Wed, 8 May 2024 17:09:18 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to eliminate direct #includes of g1_globals.hpp,
> which does nothing useful. Instead, ensure that gc_globals.hpp is included in
> all such places. Sometimes gc_globals.hpp was already included, so the include
> of g1_globals.hpp is simply deleted. Otherwise, the included file is changed
> and placement in the include list adjusted if needed to conform to HotSpot
> include order rules.
> 
> In some cases it was not obvious that the globals inclusion was needed at all,
> but I didn't explore removing any.
> 
> Testing: mach5 tier1

Marked as reviewed by tschatzl (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19144#pullrequestreview-2046306682


More information about the hotspot-gc-dev mailing list