RFR: 8331905: Fix direct includes of g1_globals.hpp [v2]

Kim Barrett kbarrett at openjdk.org
Fri May 10 08:02:35 UTC 2024


> Please review this change to eliminate direct #includes of g1_globals.hpp,
> which does nothing useful. Instead, ensure that gc_globals.hpp is included in
> all such places. Sometimes gc_globals.hpp was already included, so the include
> of g1_globals.hpp is simply deleted. Otherwise, the included file is changed
> and placement in the include list adjusted if needed to conform to HotSpot
> include order rules.
> 
> In some cases it was not obvious that the globals inclusion was needed at all,
> but I didn't explore removing any.
> 
> Testing: mach5 tier1

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into include-g1-globals
 - avoid direct includes of g1_globals.hpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19144/files
  - new: https://git.openjdk.org/jdk/pull/19144/files/8e81c29e..51664ba4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19144&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19144&range=00-01

  Stats: 16032 lines in 261 files changed: 7747 ins; 5794 del; 2491 mod
  Patch: https://git.openjdk.org/jdk/pull/19144.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19144/head:pull/19144

PR: https://git.openjdk.org/jdk/pull/19144


More information about the hotspot-gc-dev mailing list