Integrated: 8331905: Fix direct includes of g1_globals.hpp

Kim Barrett kbarrett at openjdk.org
Fri May 10 08:02:35 UTC 2024


On Wed, 8 May 2024 17:09:18 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to eliminate direct #includes of g1_globals.hpp,
> which does nothing useful. Instead, ensure that gc_globals.hpp is included in
> all such places. Sometimes gc_globals.hpp was already included, so the include
> of g1_globals.hpp is simply deleted. Otherwise, the included file is changed
> and placement in the include list adjusted if needed to conform to HotSpot
> include order rules.
> 
> In some cases it was not obvious that the globals inclusion was needed at all,
> but I didn't explore removing any.
> 
> Testing: mach5 tier1

This pull request has now been integrated.

Changeset: 7db6a3f0
Author:    Kim Barrett <kbarrett at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7db6a3f0ee3986b492786bec99b207ec36401c57
Stats:     22 lines in 9 files changed: 5 ins; 7 del; 10 mod

8331905: Fix direct includes of g1_globals.hpp

Reviewed-by: ayang, tschatzl, gli

-------------

PR: https://git.openjdk.org/jdk/pull/19144


More information about the hotspot-gc-dev mailing list