RFR: 8324649: Shenandoah: replace implementation of free set [v57]

Roman Kennke rkennke at openjdk.org
Fri May 10 18:00:20 UTC 2024


On Fri, 10 May 2024 17:54:20 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahSimpleBitMap.cpp line 2:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2016, 2021, Red Hat, Inc. All rights reserved.
>> 
>> The copyright seems wrong. This is entirely new code by you, right? Should only have Amazon copyright notice, then.
>
> Thanks for review.  I'll work through these suggestions.  Question about copyright: I guess this is pretty much "all new", but the code was derived from original code, and much of the public API was borrowed from original.  So I think maybe I should keep Red Hat copyright, and add Amazon copyright.  What do you advise?

But has it been derived from Red Hat code? My understanding was that it's basically a fork of src/hotspot/share/utilities/bitMap.* ? Which is Oracle-copyrighted. Is that correct?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1597055486


More information about the hotspot-gc-dev mailing list