RFR: 8324649: Shenandoah: replace implementation of free set [v57]

Kelvin Nilsen kdnilsen at openjdk.org
Mon May 13 03:04:21 UTC 2024


On Fri, 10 May 2024 14:16:56 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Another attempt at improving clarity of comments
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 100:
> 
>> 98: }
>> 99: 
>> 100: ShenandoahRegionPartitions::~ShenandoahRegionPartitions() {
> 
> I think there's no need to put this trivial destructor definition in the .cpp file. Just place it with the declaration in the .hpp file.

Thanks.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1597816065


More information about the hotspot-gc-dev mailing list