RFR: 8331723: Serial: Remove the unused parameter of the method SerialHeap::gc_prologue

Guoxiong Li gli at openjdk.org
Mon May 13 10:18:04 UTC 2024


On Sun, 12 May 2024 09:27:36 GMT, xiaotaonan <duke at openjdk.org> wrote:

> Serial: Remove the unused parameter of the method SerialHeap::gc_prologue

Looks good.

src/hotspot/share/gc/serial/serialHeap.hpp line 255:

> 253: 
> 254:  protected:
> 255:   virtual void gc_prologue();

The `gc_prologue` and `gc_epilogue` don't need to be marked as `virtual`. This can be done at another ticket.

-------------

Marked as reviewed by gli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19207#pullrequestreview-2052273429
PR Review Comment: https://git.openjdk.org/jdk/pull/19207#discussion_r1598226932


More information about the hotspot-gc-dev mailing list