RFR: 8331432: Clean up comments in GenArguments::initialize_size_info()

Kim Barrett kbarrett at openjdk.org
Wed May 22 03:09:04 UTC 2024


On Tue, 14 May 2024 00:40:33 GMT, xiaotaonan <duke at openjdk.org> wrote:

> Clean up comments in GenArguments::initialize_size_info()

Changes requested by kbarrett (Reviewer).

src/hotspot/share/gc/shared/genArguments.cpp line 305:

> 303:     // with other command line flags, issue a warning.
> 304:     if (initial_old_size > MaxOldSize) {
> 305:       log_warning(gc, ergo)("Inconsistency between maximum heap size and maximum "

JDK-8331432 also mentions this warning message as needing cleanup.
It should be similar to the one below about initial vs min old size, rather than incorrectly mentioning
max heap size and printing MaxHeapSize.
Except it would be useful if both includes both the initial and bound values.
Also, prefer "%zu" rather than SIZE_FORMAT when updating the messages.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19223#pullrequestreview-2070012114
PR Review Comment: https://git.openjdk.org/jdk/pull/19223#discussion_r1609197252


More information about the hotspot-gc-dev mailing list