RFR: 8331398: G1: HRPrinter reclamation events should print the original region type [v2]
Thomas Schatzl
tschatzl at openjdk.org
Thu May 23 11:42:29 UTC 2024
On Thu, 2 May 2024 08:50:25 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> currently, the various reclamation events always print `FREE` as the region type in the event string because the methods are always called after freeing.
>>
>> This is kind of useless information (obviously reclaimed regions are `FREE` after reclaiming), so this CR suggests to use the original type to understand what region has been reclaimed.
>>
>> It helped at least me a bit when debugging crashes after some refinement changes.
>>
>> This is based on PR#19013, so please have a look at it as well.
>>
>> Testing: local compilation, local testing
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - 8331398
>
> Currently, the various reclamation events always print FREE as the region type in the event string because the methods are always called after freeing.
>
> This is kind of useless information (obviously reclaimed regions are FREE after reclaiming), so this CR suggests to use the original type to understand what region has been reclaimed.
>
> Testing: local compilation, local testing
>
> Thanks,
> Thomas
> - 8331392
>
> Use different descriptions for different reclamation reasons
There were quite a few changes due to the merge, so requesting re-reviews
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19017#issuecomment-2126894313
More information about the hotspot-gc-dev
mailing list