RFR: 8332807: Parallel: Make some APIs in ParMarkBitMap private

Thomas Schatzl tschatzl at openjdk.org
Thu May 23 15:35:02 UTC 2024


On Thu, 23 May 2024 10:13:00 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Trivial moving methods from public to private.

Probably more dead code in this class to be cleaned up:

`IterationStatus::complete`; actually the return value of `do_addr()` method returning the other values is never used, so the entire enum can go away.

`is_unmarked(idx_t bit)`
`obj_granularity()`

unused forwards

`class ParCompactionManager;`
`class ParMarkBitMapClosure`

only used in .inline.hpp, so can be made private too:

`HeapWord* bit_to_addr(idx_t bit) const;`
`find_obj_beg(idx_t, idx_t)`
`verify_bit`
`verify_addr`

some other related unused methods

`ParMarkBitMapClosure::bitmap()`

May want to do this separately and more thoroughly.

-------------

Changes requested by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19360#pullrequestreview-2074344222


More information about the hotspot-gc-dev mailing list