RFR: 8330847: G1 accesses uninitialized memory when predicting eden copy time
Thomas Schatzl
tschatzl at openjdk.org
Mon May 27 11:23:06 UTC 2024
On Mon, 27 May 2024 10:06:34 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Hi all,
>>
>> please review this change that fixes survivor rate predictor initialization when expanding the survivor rate prediction tables.
>>
>> Before JDK-8231579 these predictors were not used when finalizing the collection set at gc start, and were always updated properly at the end of the GC. With that change G1 started using these uninitialized predictors.
>>
>> There is an assert that should fail in the future if there is a bug.
>>
>> Testing: tier1-3
>>
>> Thanks,
>> Thomas
>
> LGTM!
Thanks @walulyai @albertnetymk for your reviews
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19364#issuecomment-2133260923
More information about the hotspot-gc-dev
mailing list