RFR: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless. [v2]
Albert Mingkun Yang
ayang at openjdk.org
Wed May 29 10:16:03 UTC 2024
On Wed, 29 May 2024 08:15:29 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Hi all,
>>
>> Please review this change to trigger SkippedException instead of RunTimeExceptions when a test is deemed useless because of full-GCs. The test triggers frequent `System.gc()` calls which in some cases may aggressively shrink the heap, and subsequent allocations lead to full-GC. This may affect the usefulness of the test, but it is not a test failure. So we added SkippedException to indicate this situation.
>>
>> Testing: Local testing with very small heaps.
>> Tier 1.
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>
> Thomas Review
Marked as reviewed by ayang (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/19432#pullrequestreview-2084979617
More information about the hotspot-gc-dev
mailing list