RFR: 8343507: Parallel: Fail if verify_complete finds incorrect states

[Thomas Schatzl]

On Mon, 4 Nov 2024 05:31:26 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Trivial change of replacing `log_warning` with `fatal`, because incorrect `destination_count` always indicate some problem.
> 
> Test: tier1-3

Changes requested by tschatzl (Reviewer).

src/hotspot/share/gc/parallel/psParallelCompact.cpp line 1917:

> 1915:     if (!c->completed()) {
> 1916:       fatal("region %zu not filled: destination_count=%u",
> 1917:              cur_region, c->destination_count());

I would prefer to use `assert(c->completed(), ...)` in both cases similar to other failures due to verification (like the one above).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21865#pullrequestreview-2412338308
PR Review Comment: https://git.openjdk.org/jdk/pull/21865#discussion_r1827295363