RFR: 8342041: Test gc/shenandoah/oom/TestClassLoaderLeak.java slow on Windows after JDK-8340490 [v3]
Xiaolong Peng
xpeng at openjdk.org
Sat Nov 16 19:49:20 UTC 2024
> Fixing the regression on Windows caused by JDK-8340490, the bug is actually caused by different behavior in `os:: os::elapsed_counter()` which I wasn't aware of. Windows doesn't have nanosecond hi-res clock support, so instead of nanoseconds it returns the the current value of the performance counter([link](https://learn.microsoft.com/en-us/windows/win32/api/profileapi/nf-profileapi-queryperformancecounter)).
>
> ### Tests
> - [x] Verify gc/shenandoah/oom/TestClassLoaderLeak.java on Windows, no regression at all(improved slightly by ~1s comparing to original impl)
> - [x] Run test suites hotspot_gc_shenandoah with linux-aarch64-server-fastdebug
Xiaolong Peng has updated the pull request incrementally with two additional commits since the last revision:
- Revert all the changes not related to the bug fix
- Simplify pace_for_alloc
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22172/files
- new: https://git.openjdk.org/jdk/pull/22172/files/d83dfbd4..19e782c6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22172&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22172&range=01-02
Stats: 27 lines in 2 files changed: 9 ins; 9 del; 9 mod
Patch: https://git.openjdk.org/jdk/pull/22172.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22172/head:pull/22172
PR: https://git.openjdk.org/jdk/pull/22172
More information about the hotspot-gc-dev
mailing list