RFR: 8345173: BlockLocationPrinter::print_location misses a ResourceMark

Stefan Johansson sjohanss at openjdk.org
Fri Nov 29 13:55:37 UTC 2024


On Fri, 29 Nov 2024 09:36:16 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this small change that adds a missing `ResourceMark` to `BlockLocationPrinter`; it can be called at very arbitrary places (e.g. the stop() method of MacroAssembler), and without this change it might fail with a "Missing ResourceMark error - possible memory leak" error instead of providing the stop() output (and then faiiling).
> 
> Testing: local testing, after the change the ResourceMark crash goes away, gha
> 
> Thanks,
>   Thomas

Marked as reviewed by sjohanss (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22455#pullrequestreview-2469968711


More information about the hotspot-gc-dev mailing list