RFR: 8339668: Parallel: Adopt PartialArrayState to consolidate marking stack in Full GC
Zhengyu Gu
zgu at openjdk.org
Tue Oct 1 19:23:35 UTC 2024
On Tue, 1 Oct 2024 17:02:19 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
>> I ran into the same problem for G1 Full GC that @zhengyu123 has run into here. ScannerTask deals in
>> _pointers_ to `oop` (and `narrowOop`). For the separate marking cases we have `oop`s in the tasks.
>> I added a class just like this one in my work, except I put mine in gc/shared and gave it a different name
>> (OopScannerTask, which I don't love). Clearly some coalescing is needed there.
>
>> OopScannerTask
>
> I certainly can adopt your implementation once it is integrated.
> Please use `ScannerTask` instead; it seems to be completely serviceable for that purpose. In fact, a search&replace seems just fine.
>
> https://github.com/openjdk/jdk/compare/pr/21089...tschatzl:jdk:pull/21089-recommendations?expand=1
>
> I am going to experiment with refactoring the other duplicated (statistics) code
I believe I ran into alignment assertion failure with `ScannerTask`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21089#discussion_r1783371791
More information about the hotspot-gc-dev
mailing list