RFR: 8339668: Parallel: Adopt PartialArrayState to consolidate marking stack in Full GC [v3]
Zhengyu Gu
zgu at openjdk.org
Wed Oct 2 14:26:15 UTC 2024
On Wed, 2 Oct 2024 09:26:48 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>>>I ran into the same problem for G1 Full GC that @zhengyu123 has run into here. ScannerTask deals in
>> pointers to oop (and narrowOop). For the separate marking cases we have oops in the tasks.
>> I added a class just like this one in my work, except I put mine in gc/shared and gave it a different name
>> (OopScannerTask, which I don't love). Clearly some coalescing is needed there.
>>
>> The suggested patch just adds constructor to allow a regular `oop` and the associated getter. Internally `ScannerTask` uses a `void*` anyway.
>> Probably I am overlooking something trivial here why having an interface to store and retrieve an `oop` is not possible.... seems to pass very basic testing though.
>
> (Fwiw, https://github.com/tschatzl/jdk/tree/submit/pull/21089-recommendations-test with the suggested changes seems to pass GHA....)
I missed `ScannerTask` constructor change :-( the suggested changes also passed tier1 with Parallel GC.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21089#discussion_r1784622909
More information about the hotspot-gc-dev
mailing list