RFR: 8334060: Implementation of Late Barrier Expansion for G1 [v27]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Wed Oct 2 19:43:50 UTC 2024
On Wed, 2 Oct 2024 12:55:13 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> It could, but the effect would be the same (see [JDK-8058880](https://bugs.openjdk.org/browse/JDK-8058880)). I went with `TEMP` for the x64 and aarch64 platforms for consistency with the analogous ZGC ADL code, see e.g. https://github.com/openjdk/jdk/blob/855c8a7def21025bc2fc47594f7285a55924c213/src/hotspot/cpu/aarch64/gc/z/z_aarch64.ad#L182-L204.
>
> I saw the riscv one in z_riscv.ad is: `effect(TEMP oldval_tmp, TEMP newval_tmp, TEMP tmp1, TEMP_DEF res);`, maybe it's good to change riscv one?
I suggest to postpone these types of refactorings to follow-up enhancements, given that the pull request in its current form is stable, thoroughly tested, and approved by reviewers. I intend to integrate it within the following 24 hours, provided final test results look good.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1785135652
More information about the hotspot-gc-dev
mailing list