RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]
Sandhya Viswanathan
sviswanathan at openjdk.org
Wed Oct 9 16:25:23 UTC 2024
On Wed, 9 Oct 2024 06:25:28 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Oh! We need to increase the compiler stub size for the indexOf changes. Strange that it blows up like this, I was sure there was a better check for this somewhere. I changed it like this, let me know if you agree that this is the correct fix:
>> https://github.com/openjdk/jdk/pull/20677/commits/b289ef885816958d9806c76f473b10e34a39e247
>
> That seems to work, thanks @rkennke!
>
> Since the [indexOf changes](https://github.com/openjdk/jdk/pull/20677/files#diff-ae1139bb5342494f9761e04389b090c543391bfdd7817af1625e854357c96e63) are complex and affect the default JVM configuration, they should be subject to the same level of scrutiny as if they were a standalone RFE, i.e. approved by at least a second reviewer. @sviswa7 could someone else at Intel have a second look and explicitly approve them?
Yes, @vpaprotsk could review the changes that we made in src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1793814453
More information about the hotspot-gc-dev
mailing list