RFR: 8337269: G1ConfidencePercent interpreted inconsistently [v2]

[Thomas Schatzl]

On Fri, 11 Oct 2024 00:40:25 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Retracting my prior approval.
> 
> I think the proposed change does address the described inconsistency. But I think it doesn't go far enough.
> 
> The G1Predictions constructor takes a "sigma" argument. It range checks it, and the failure message describes it as "confidence". The accessor for that value is described as "Confidence factor". That seems inconsistent with the usage (a small value suggests higher confidence in the average value), and with the new calculation of the argument.

I renamed the member as it had a wrong name anyway; sigma is the actual value of the stddev, not some factor. I hope this is good enough to address your concerns.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21448#issuecomment-2407394676