RFR: 8342119: Shenandoah: Remove extra ShenandoahUpdateRefsClosure [v2]

Aleksey Shipilev shade at openjdk.org
Thu Oct 17 16:51:38 UTC 2024


On Thu, 17 Oct 2024 14:16:47 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> We have a duplicate `ShenandoahUpdateRefsClosure`, which we use in a few places. For bulk GC operations, we have `ShenandoahConcUpdateRefsClosure` and `ShenandoahSTWUpdateRefsClosure` that are semantically similar to that one. We can drop the `ShenandoahUpdateRefsClosure` in favor of these two existing ones. 
>> 
>> Additional testing:
>>  - [x] Linux x86_64 server fastdebug, `hotspot_gc_shenandoah`
>>  - [x] Performance tests (no regressions)
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8342119-shenandoah-remove-extra-ur-cl
>  - Switch back to non-concurrent closure, rename update methods
>  - Fix

Thank you!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21517#issuecomment-2420033090


More information about the hotspot-gc-dev mailing list