RFR: 8342610: ZGC: Cleanup pre-touching code
Axel Boldt-Christmas
aboldtch at openjdk.org
Mon Oct 21 09:12:50 UTC 2024
On Mon, 21 Oct 2024 08:15:16 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> There's a few things that we'd like to cleanup around the pre-touching code.
> * Remove the dependency to ZPhysicalMemoryManager - cleans up the call site
> * Remove unimplemented function pretouch_view (and its friends)
> * Change type from zoffset for the iteration variable - multiple threads update it and it is not guaranteed to stay below the required ZAddressOffsetMax. I can trigger an assert here if I change the code to prime_cache in the higher address range instead of the lower and setting a max heap size that matches ZAddressOffsetMax.
lgtm.
-------------
Marked as reviewed by aboldtch (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21600#pullrequestreview-2381407369
More information about the hotspot-gc-dev
mailing list