RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option

[Aleksey Shipilev]

On Mon, 21 Oct 2024 13:00:23 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> Newly added test `gc/shenandoah/compiler/TestLoadBypassesNullCheck.java` fails `The unlock option must precede 'StressGCM'.` with release jdk build. This PR fix the test bug, only add `-XX:+UnlockDiagnosticVMOptions` to make test run passed by release jdk build.
> The change has been verified locally with release/fastdebug/slowdebug on linux-x64. Test-fix only, no risk.

Marked as reviewed by shade (Reviewer).

test/hotspot/jtreg/gc/shenandoah/compiler/TestLoadBypassesNullCheck.java line 33:

> 31:  * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:-TieredCompilation -XX:-UseOnStackReplacement -XX:-BackgroundCompilation
> 32:  *                   -XX:+StressGCM -XX:+StressLCM -XX:+UseShenandoahGC -XX:LoopMaxUnroll=0 -XX:StressSeed=270847015
> 33:  *                   TestLoadBypassesNullCheck

I am good with this fix, but if you have time to re-test it, consider reshuffling the arguments a bit, so that we only unlock what we need:


 * @run main/othervm -XX:-TieredCompilation -XX:-UseOnStackReplacement -XX:-BackgroundCompilation 
 *                   -XX:+UseShenandoahGC -XX:LoopMaxUnroll=0
 *                   -XX:+UnlockDiagnosticVMOptions -XX:+StressGCM -XX:+StressLCM -XX:StressSeed=270847015
 *                   TestLoadBypassesNullCheck

-------------

PR Review: https://git.openjdk.org/jdk/pull/21609#pullrequestreview-2382559833
PR Review Comment: https://git.openjdk.org/jdk/pull/21609#discussion_r1809092713