RFR: 8342610: ZGC: Cleanup pre-touching code [v2]
Axel Boldt-Christmas
aboldtch at openjdk.org
Tue Oct 22 09:32:13 UTC 2024
On Tue, 22 Oct 2024 07:55:00 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> There's a few things that we'd like to cleanup around the pre-touching code.
>> * Remove the dependency to ZPhysicalMemoryManager - cleans up the call site
>> * Remove unimplemented function pretouch_view (and its friends)
>> * Change type from zoffset for the iteration variable - multiple threads update it and it is not guaranteed to stay below the required ZAddressOffsetMax. I can trigger an assert here if I change the code to prime_cache in the higher address range instead of the lower and setting a max heap size that matches ZAddressOffsetMax.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>
> Add explicit include of os.hpp
Marked as reviewed by aboldtch (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21600#pullrequestreview-2384565740
More information about the hotspot-gc-dev
mailing list