RFR: 8342588: Shenandoah: Pull shared closures together in one header [v2]

Volker Simonis simonis at openjdk.org
Tue Oct 29 17:02:08 UTC 2024


On Fri, 18 Oct 2024 10:31:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Currently we have shenandoahClosures.hpp and shenandoahOopClosures.hpp, each of which have some closure inside. There is no reason to have this separation, and we should really just merge everything in one header. I also did a bit of mechanical renames. There should be no semantic change with this patch.
>> 
>> Additional testing:
>>  - [x] Linux x86_64 server fastdebug, `hotspot_gc_shenandoah`
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix Zero builds

In general looks good. The only thing I'd recommend (if you haven't done that already anyway) would be to configure with `--disable-precompiled-headers` and see if the build still works (i.e. if all the inline functions are still all available in all the compilation units).

-------------

Marked as reviewed by simonis (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21579#pullrequestreview-2402576093


More information about the hotspot-gc-dev mailing list