RFR: 8340400: Shenandoah: Whitebox breakpoint GC requests may cause assertions

[Aleksey Shipilev]

On Wed, 18 Sep 2024 21:02:23 GMT, William Kemper <wkemper at openjdk.org> wrote:

> When a test requests a concurrent GC breakpoint, the calling thread arranges for itself to block until the concurrent GC thread notifies it that the GC has reached the requested breakpoint (phase). The code that handles the whitebox breakpoint request should therefore not block the caller. An attempt was made to do this, but the request just has the caller thread run in a busy loop without waiting. What's more, this loop resets the requested gc cause on every iteration, which may lead to gc cycles with a wb_breakpoint cause, but no breakpoint set - which violates assertions.

Yeah, this makes sense. Any tests fail without this patch?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21074#pullrequestreview-2315363086