RFR: 8340419: ZGC: Create an UseLargePages adaptation of TestAllocateHeapAt.java

Stefan Johansson sjohanss at openjdk.org
Wed Sep 25 08:05:43 UTC 2024


On Mon, 23 Sep 2024 07:28:15 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

> [JDK-8340146](https://bugs.openjdk.org/browse/JDK-8340146) / #21127  disables TestAllocateHeapAt.java when running with persistent hugepages because it makes assumptions on the underlying file systems.
> 
> I propose creating a version of this tests which instead first checks if there is an appropriate mount point for a persistent hugepages heap file, and only runs the test if exists.

Looks good.

test/hotspot/jtreg/gc/z/TestAllocateHeapAtWithHugeTLBFS.java line 80:

> 78:         ProcessTools.executeTestJava(
> 79:             "-XX:+UseZGC",
> 80:             "-XX:+ZGenerational",

Any reason to include `-XX:+ZGenerational` or should we just skip it?

-------------

Marked as reviewed by sjohanss (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21128#pullrequestreview-2327468399
PR Review Comment: https://git.openjdk.org/jdk/pull/21128#discussion_r1774745690


More information about the hotspot-gc-dev mailing list