RFR: 8341015: OopStorage location decoder crashes accessing non-initalized OopStorage [v2]

Thomas Schatzl tschatzl at openjdk.org
Thu Sep 26 12:55:35 UTC 2024


On Thu, 26 Sep 2024 12:43:40 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/oopStorageSet.cpp line 89:
>> 
>>> 87:     const void* aligned_addr = align_down(addr, alignof(oop));
>>> 88:     for (OopStorage* storage : Range<Id>()) {
>>> 89:       if (storage != nullptr && storage->print_containing((oop*) aligned_addr, st)) {
>> 
>> Add a comment?  Something like "Might get here while handling error before storage initialization."
>
> Sure thing, see new commit.

Another maybe preferable option could be printing "uninitialized" or something.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21204#discussion_r1777011233


More information about the hotspot-gc-dev mailing list