RFR: 8341015: OopStorage location decoder crashes accessing non-initalized OopStorage [v2]

[Kim Barrett]

On Thu, 26 Sep 2024 12:47:47 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> When debugging CDS, I asked for `os::print_location` before OopStorage was initialized, like an error handler would do. This is a fairly unusual situation, this is why we have not seen it before. Anyhow, we entered the new code added by [JDK-8340392](https://bugs.openjdk.org/browse/JDK-8340392), which crashed on `OopStorage` that was `nullptr`. I think we should null-check `OopStorage` before calling into it.
>> 
>> Additional testing:
>>  - [x] OopStorageSetTest still passing
>>  - [x] Verified the check is now passing in similar debugging session
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Touchups

Still looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21204#pullrequestreview-2331218638