RFR: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int' [v3]

Paul Hohensee phh at openjdk.org
Sun Sep 29 21:01:34 UTC 2024


On Fri, 27 Sep 2024 23:39:15 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Use a template version of `right_n_bits` to use the same type for minuend and subtrahend.
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix comments

Rather than define a new method get_right_n_bits(), why not just replace the definition of right_n_bits() in globalDefinitions.hpp? The C++ compiler will inline and optimize both.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21236#pullrequestreview-2335997131


More information about the hotspot-gc-dev mailing list