RFR: 8211400: nsk.share.gc.Memory::getArrayLength returns wrong value

[Kim Barrett]

On Sun, 29 Sep 2024 08:33:31 GMT, Ramkumar Sunderbabu <rsunderbabu at openjdk.org> wrote:

> Current formula is incorrect since array doesn't use reference for each element.
> 
> Tested with test groups,
> vmTestbase_vm_gc_ref
> vmTestbase_vm_gc_juggle
> vmTestbase_vm_gc_misc

I've never looked at this file before.  Wow!  Several problems spotted on just brief
skimming!  But out of scope for this specific issue.

test/hotspot/jtreg/vmTestbase/nsk/share/gc/Memory.java line 166:

> 164:          */
> 165:         public static long getArraySize(int length, long objectSize) {
> 166:                 return getObjectExtraSize() + length * objectSize;

pre-existing: Shouldn't that be getArrayExtraSize()?

-------------

Changes requested by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21247#pullrequestreview-2336196756
PR Review Comment: https://git.openjdk.org/jdk/pull/21247#discussion_r1780306207