RFR: 8352994: ZGC: Fix regression introduced in JDK-8350572

[Stefan Karlsson]

On Tue, 1 Apr 2025 06:58:56 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> We have seen a bunch of timeouts that all points towards the introduction of a check against VMError::is_error_reported_in_current_thread() in the ZGC verification code. I propose this workaround to first check if there's really an error reporting event that is going on by checking VMError::is_error_reported().
> 
> The underlying performance issue (or hang(?)) when calling os::current_thread_id() is being investigated as a separate bug. This fix just tries to clean up issues we see when running ZGC testing.
> 
> Thanks to @plummercj for digging into this and proposing the same workaround.
> 
> Testing: GHA is clean, I'll run this through a few tiers of our CI pipeline

I've removed the test and will run tier1-tier3.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24349#issuecomment-2772225278