RFR: 8352994: ZGC: Fix regression introduced in JDK-8350572 [v2]

[Axel Boldt-Christmas]

On Wed, 2 Apr 2025 11:15:01 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> We have seen a bunch of timeouts that all points towards the introduction of a check against VMError::is_error_reported_in_current_thread() in the ZGC verification code. I propose this workaround to first check if there's really an error reporting event that is going on by checking VMError::is_error_reported().
>> 
>> The underlying performance issue (or hang(?)) when calling os::current_thread_id() is being investigated as a separate bug. This fix just tries to clean up issues we see when running ZGC testing.
>> 
>> Thanks to @plummercj for digging into this and proposing the same workaround.
>> 
>> Testing: GHA is clean, I'll run this through a few tiers of our CI pipeline
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove test from ProblemList

A good local fix. 

But I also think `VMError::is_error_reported_in_current_thread()` should do `return is_error_reported() && _first_error_tid == os::current_thread_id();` Given that `current_thread_id` has a non trivial cost.

-------------

Marked as reviewed by aboldtch (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24349#pullrequestreview-2739468102