RFR: 8351091: Shenandoah: global marking context completeness is not accurately maintained [v7]

Y. Srinivas Ramakrishna ysr at openjdk.org
Thu Apr 3 21:55:07 UTC 2025


On Thu, 6 Mar 2025 23:09:47 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> OK, yes, that makes sense. Why not then use both `ShenandoahHeap::[complete_]marking_context()` as synonyms for `ShehandoahHeap::active_generation()->[complete_]marking_context()`. See other related comments in this review round.
>
> I feel using `henandoahHeap::complete_marking_context()` as synonyms for `ShehandoahHeap::active_generation()->[complete_]marking_context()` may cause more confusion, just read from the name it seems that it indicates the marking is complete for the whole heap, not just the active generation.

ok, that makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23886#discussion_r2027790148


More information about the hotspot-gc-dev mailing list