RFR: 8354145: G1GC: keep the CompressedOops same as before when not setting HeapRegionSize explicitly [v2]

[Tongbao Zhang]

On Tue, 15 Apr 2025 01:52:22 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Tongbao Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   G1GC: keep the CompressedOops same as before when not setting HeapRegionSize explicitly
>
> test/hotspot/jtreg/gc/arguments/TestG1CompressedOops.java line 30:
> 
>> 28:  * @test TestG1CompressedOops
>> 29:  * @bug 8354145
>> 30:  * @requires vm.gc.G1 & vm.opt.G1HeapRegionSize == null
> 
> The test ignores external VM flags, so vm.opt.G1HeapRegionSize is not needed.
> But it is needed to add
> `* @requires vm.flagless`

done

> test/hotspot/jtreg/gc/arguments/TestG1CompressedOops.java line 32:
> 
>> 30:  * @requires vm.gc.G1 & vm.opt.G1HeapRegionSize == null
>> 31:  * @summary Verify that the flag TestG1CompressedOops is updated properly
>> 32:  * @modules java.base/jdk.internal.misc
> 
> Is any of those 2 modules is used by tests? I don't see it in the test.

removed these two modules

> Why this line is needed? I don't see any dependencies on "/" If you use some test code outside directory, better to build them.

Yes, the GCArguments depends on the  ```@library /``` , many tests in ``` test/hotspot/jtreg/gc/arguments``` use this

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24541#discussion_r2043407145
PR Review Comment: https://git.openjdk.org/jdk/pull/24541#discussion_r2043406996
PR Review Comment: https://git.openjdk.org/jdk/pull/24541#discussion_r2043406500