RFR: 8354228: Parallel: Set correct minimum of InitialSurvivorRatio [v3]

Guoxiong Li gli at openjdk.org
Wed Apr 23 04:37:41 UTC 2025


On Tue, 22 Apr 2025 07:55:17 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Updating the lower bound of InitialSurvivorRatio to match MinSurvivorRatio. The two removed test cases set conflicting Min and Intial SurvivorRatio, which, IMO, is an incorrect configuration, so I removed them.
>> 
>> Test: tier1-7
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into pgc-min-initial-fix
>  - review
>  - pgc-min-initial-fix

> the default values should be MinSurvivorRatio == 3 and InitialSurvivorRatio == 8 (as defined in gc_globals.hpp), so MinSurvivorRatio <= InitialSurvivorRatio should hold.

The patch looks fine, though I have a different viewpoint.

-------------

Marked as reviewed by gli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24556#pullrequestreview-2785902574


More information about the hotspot-gc-dev mailing list