RFR: 8353596: GenShen: Test TestClone.java#generational-no-coops intermittent timed out

[Y. Srinivas Ramakrishna]

On Wed, 23 Apr 2025 22:57:52 GMT, William Kemper <wkemper at openjdk.org> wrote:

> That's a good call out. I don't believe `ShenandoahControlThread` is affected by this same issue because it will notify if `_gc_requested` is set, and doesn't care about the _cause_ of the gc.

Correct.

> I did also consider adding `_codecache_GC_threshold` as a cause for explicit gc, except I'm not sure it really is (in the sense that the user did not explicitly request it). Also, it felt like a losing game because the next time a new gc cause is added, we'd need to evaluate whether or not it was `explicit`.

I agree that this works better as it notifies gc waiters in all cases.

One question is where `_gc_requested` is reset and whether to keep the two controllers' logic similar, if an identical condition were used here (or an identical condition were used in the case of non-generational controller), and if not why it would not work (perhaps because the requests are handled differently). But, yes, such a clean-up is for another day, not this PR.

🚢

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24834#issuecomment-2825719660