RFR: 8231269: CompileTask::is_unloaded is slow due to JNIHandles type checks [v6]

Aleksey Shipilev shade at openjdk.org
Fri Apr 25 09:49:53 UTC 2025


On Thu, 24 Apr 2025 00:22:47 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Allow UMH::_method access from VMStructs
>
> src/hotspot/share/runtime/unloadableMethodHandle.inline.hpp line 37:
> 
>> 35: inline UnloadableMethodHandle::UnloadableMethodHandle(Method* method) {
>> 36:   _method = method;
>> 37:   if (method != nullptr) {
> 
> Is it possible to require `method` (and hence `_method`) to always be non-null?

Yes, we can. This is a remnant of the implementation that accepted `_hot_method == nullptr`. Not needed now, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24018#discussion_r2059922071


More information about the hotspot-gc-dev mailing list