RFR: 8364516: Serial: Move class unloading logic inside SerialFullGC::invoke_at_safepoint [v3]

Thomas Schatzl tschatzl at openjdk.org
Mon Aug 4 08:07:57 UTC 2025


On Fri, 1 Aug 2025 16:54:45 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Encapsulating classunloading logic inside `invoke_at_safepoint` and adding doc explaining why the classunloading logic can't be placed at the end of marking during full-gc, like other STW collectors.
>> 
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review

Sorry, one more typo I apparently forgot last time.

src/hotspot/share/gc/serial/serialFullGC.cpp line 708:

> 706:   allocate_stacks();
> 707: 
> 708:   // Usually, all class unloading works occurs at the end of phase 1, but Serial

Suggestion:

  // Usually, all class unloading work occurs at the end of phase 1, but Serial

-------------

Changes requested by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26588#pullrequestreview-3083136375
PR Review Comment: https://git.openjdk.org/jdk/pull/26588#discussion_r2250730716


More information about the hotspot-gc-dev mailing list