RFR: 8364531: G1: Factor out liveness tracing code [v3]

Albert Mingkun Yang ayang at openjdk.org
Mon Aug 4 08:27:01 UTC 2025


On Fri, 1 Aug 2025 13:33:34 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this refactoring, eliminating some copy&paste, in cset candidate group liveness logging.
>> 
>> The output is mostly the same, except for the young cset group, where the "-" has been replaced to just print the default value (0.0) for efficiency. I did not see this important to have, the gc efficiency for young gen isn't interesting.
>> 
>> Testing: local compilation, gha, visual inspection of output
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   * more refactoring

Marked as reviewed by ayang (Reviewer).

src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 3166:

> 3164:   _total_remset_bytes += g1h->young_regions_cset_group()->card_set()->mem_size();
> 3165: 
> 3166:   G1CollectionSetCandidates * candidates = g1h->policy()->candidates();

Why both spaces around `*`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/26591#pullrequestreview-3083189963
PR Review Comment: https://git.openjdk.org/jdk/pull/26591#discussion_r2250770386


More information about the hotspot-gc-dev mailing list