RFR: 8364531: G1: Factor out liveness tracing code [v4]

Sangheon Kim sangheki at openjdk.org
Mon Aug 4 20:05:06 UTC 2025


On Mon, 4 Aug 2025 09:45:50 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this refactoring, eliminating some copy&paste, in cset candidate group liveness logging.
>> 
>> The output is mostly the same, except for the young cset group, where the "-" has been replaced to just print the default value (0.0) for efficiency. I did not see this important to have, the gc efficiency for young gen isn't interesting.
>> 
>> Testing: local compilation, gha, visual inspection of output
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   * fix typo

Looks good as is.

This might be a preference thing.
log_xxx_group() doesn't update _total_remset_bytes while log_xxx_grouplist() updates it. It might be better to update it from log_xxx_group() with or without proper name change? e.g. append_total_and_log_cset_candidate()

-------------

Marked as reviewed by sangheki (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26591#pullrequestreview-3085582595


More information about the hotspot-gc-dev mailing list